chrome/app/generated_resources.grd - Issue 927293002: platformKeys: Hook up the certificate selection dialog to selectClientCertificates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 927293002: platformKeys: Hook up the certificate selection dialog to selectClientCertificates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_perms

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/platform_keys/platform_keys_service.h » ('j') | chrome/browser/chromeos/platform_keys/platform_keys_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 4f45f6d9776424fadd4ac31947ac758866aa7127..eb213ec1455880f5d7818b1404b0d5353efbd415 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -9977,6 +9977,12 @@ I don't think this site should be blocked!

Connect

</message>

+

msw 2015/02/19 20:21:54 You're really supposed to have new strings in 2 we

pneubeck (no reviews) 2015/02/19 21:51:40 Acknowledged.

+ <message name="IDS_PLATFORM_KEYS_SELECT_CERT_DIALOG_TEXT" desc="The text in the dialog that prompts for a certificate when an extension requested certificates through the platformKeys API.">

bartfab (slow) 2015/02/19 18:55:42 Nit: s/prompts for/prompts the user to select/ Nit

pneubeck (no reviews) 2015/02/19 21:51:40 Done.

+ Extension '<ph name="EXTENSION_NAME">$1<ex>Better OpenVPN App</ex>' has requested a certificate. Selecting a certificate will grant the extension the ability to use this identity with servers now and in the future. You should only select a certificate if you trust the extension.

bartfab (slow) 2015/02/19 18:55:42 The </ph> belongs at the end of the placeholder, n

pneubeck (no reviews) 2015/02/19 21:51:40 Done.

+ </ph>

+ </message>

This frame was blocked because it contains some insecure content.