platformKeys: Hook up the certificate selection dialog to selectClientCertificates.

chrome/browser/chromeos/platform_keys/platform_keys_service.h

Index: chrome/browser/chromeos/platform_keys/platform_keys_service.h
diff --git a/chrome/browser/chromeos/platform_keys/platform_keys_service.h b/chrome/browser/chromeos/platform_keys/platform_keys_service.h
index 082ef20071fe8b5a55ca0aa94f1777e4a5c5663a..8463bdb533269e3ca214b65c01bfe0290d20ad7e 100644
--- a/chrome/browser/chromeos/platform_keys/platform_keys_service.h
+++ b/chrome/browser/chromeos/platform_keys/platform_keys_service.h
@@ -19,6 +19,7 @@
 
 namespace content {
 class BrowserContext;
+class WebContents;
 }
 
 namespace base {
@@ -47,9 +48,8 @@ class PlatformKeysService : public KeyedService {
   // can happen by exposing UI to let the user select.
   class SelectDelegate {
    public:
-    // TODO(pneubeck): Handle if the selection was aborted, e.g. by the user.
-    using CertificateSelectedCallback =
-        base::Callback<void(scoped_refptr<net::X509Certificate> selection)>;
+    using CertificateSelectedCallback = base::Callback<void(
+        const scoped_refptr<net::X509Certificate>& selection)>;
 
     SelectDelegate();
     virtual ~SelectDelegate();
@@ -63,7 +63,9 @@ class PlatformKeysService : public KeyedService {
     // called after this delegate is destructed.
     virtual void Select(const std::string& extension_id,
                         const net::CertificateList& certs,
-                        const CertificateSelectedCallback& callback) = 0;
+                        const CertificateSelectedCallback& callback,
+                        content::WebContents* web_contents,

[bartfab (slow), 2015/02/19 18:55:42]

Nit: Document that |web_contents| will not be a nullptr and provides the context
for which a certificate is needed.

[pneubeck (no reviews), 2015/02/19 21:51:40]

Done.

+                        content::BrowserContext* context) = 0;
 
    private:
     DISALLOW_ASSIGN(SelectDelegate);
@@ -169,7 +171,8 @@ class PlatformKeysService : public KeyedService {
       const platform_keys::ClientCertificateRequest& request,
       bool interactive,
       const std::string& extension_id,
-      const SelectCertificatesCallback& callback);
+      const SelectCertificatesCallback& callback,
+      content::WebContents* web_contents);

[bartfab (slow), 2015/02/19 18:55:42]

Nit: Document that |web_contents| must not be a nullptr.

[pneubeck (no reviews), 2015/02/19 21:51:40]

Done.

 
  private:
   using GetPlatformKeysCallback =