Issue 92723002: [Android] Make exceptions when starting MinidumpUploadService non-fatal.

Issue 92723002: [Android] Make exceptions when starting MinidumpUploadService non-fatal. (Closed)

Created:
7 years ago by frankf

Modified:
7 years ago

Reviewers:
craigdh

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Make exceptions when starting MinidumpUploadService non-fatal. Sometimes we get "android.util.AndroidException: Can't connect to activity manager; is the system running?". So starting the service should be best-effort. BUG=None R=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237626

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed style issue #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	build/android/pylib/monkey/test_runner.py	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

craigdh

This is the wrong place to do it, but it seems like the release-tests monkey ...

7 years ago (2013-11-27 21:39:38 UTC) #2

craigdh

https://codereview.chromium.org/92723002/diff/1/build/android/pylib/monkey/test_runner.py File build/android/pylib/monkey/test_runner.py (right): https://codereview.chromium.org/92723002/diff/1/build/android/pylib/monkey/test_runner.py#newcode93 build/android/pylib/monkey/test_runner.py:93: except AssertionError, e: "except AssertionError as e:" is more ...

7 years ago (2013-11-27 21:40:43 UTC) #3

frankf

7 years ago (2013-11-27 21:44:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r237626 (presubmit successful).

Expand Messages | Collapse Messages