Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: build/android/pylib/monkey/test_runner.py

Issue 92723002: [Android] Make exceptions when starting MinidumpUploadService non-fatal. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed style issue Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/monkey/test_runner.py
diff --git a/build/android/pylib/monkey/test_runner.py b/build/android/pylib/monkey/test_runner.py
index 1920464547fa4882869db0bfb03a053d76506133..76eb623bb4cc9fc52bcad6ed94495babdd8f9d21 100644
--- a/build/android/pylib/monkey/test_runner.py
+++ b/build/android/pylib/monkey/test_runner.py
@@ -87,7 +87,10 @@ class TestRunner(base_test_runner.BaseTestRunner):
result = base_test_result.BaseTestResult(
test_name, base_test_result.ResultType.FAIL, log=output)
if 'chrome' in self._options.package:
- logging.warning('Start MinidumpUploadService...')
- self.adb.StartCrashUploadService(self._package)
+ logging.warning('Starting MinidumpUploadService...')
+ try:
+ self.adb.StartCrashUploadService(self._package)
+ except AssertionError as e:
+ logging.error('Failed to start MinidumpUploadService: %s', e)
results.AddResult(result)
return results, False
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698