Chromium Code Reviews
Help | Chromium Project | Sign in
(23)

Issue 9271025: Update Gaia URL. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by xiyuan
Modified:
3 years, 6 months ago
Reviewers:
wtc, zel, Evan Stade
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Update Gaia URL. - Change Gaia service url base: https://www.google.com/accounts/ -> https://accounts.google.com/ - Leave federated login as it was as it's not moved; - Update GaiaOAuthFetcher to report error instead of NOTREACHED when redirected to ServiceLogin; - Move GetValueForKeyInQuery from sync_promo_ui.cc to browser_url_util.cc; BUG=chromium-os:24612 TEST=Should use accounts.google.com for Gaia and login/sync etc should work as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118627

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nit #

Total comments: 2

Patch Set 3 : fix nits, fix unit_tests failure and update license headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -55 lines) Patch
M chrome/browser/chromeos/login/mock_url_fetchers.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/browser_url_util.h View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/net/browser_url_util.cc View 1 2 3 chunks +26 lines, -1 line 0 comments Download
M chrome/browser/net/browser_url_util_unittest.cc View 1 2 2 chunks +20 lines, -1 line 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher.cc View 1 2 3 chunks +41 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 1 2 4 chunks +8 lines, -31 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/net/gaia/gaia_urls.h View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M chrome/common/net/gaia/gaia_urls.cc View 1 2 5 chunks +28 lines, -14 lines 0 comments Download
Commit: (user is not authenticated) CQ not working?

Messages

Total messages: 10 (0 generated)
xiyuan
This is the chromium side change. Gaia auth ext change is at https://gerrit.chromium.org/gerrit/#change,13525
3 years, 6 months ago (2012-01-21 00:45:41 UTC) #1
zel
LGTM with a nit: http://codereview.chromium.org/9271025/diff/1/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (right): http://codereview.chromium.org/9271025/diff/1/chrome/browser/chromeos/login/login_utils.cc#newcode863 chrome/browser/chromeos/login/login_utils.cc:863: VLOG(1) << "Start fetch oauth1 ...
3 years, 6 months ago (2012-01-21 00:54:22 UTC) #2
xiyuan
+wtc, estade Owner of net and ui/webui, please approve. Thanks.
3 years, 6 months ago (2012-01-21 01:01:18 UTC) #3
wtc
Patch set 2 LGTM. http://codereview.chromium.org/9271025/diff/1002/chrome/browser/net/browser_url_util.h File chrome/browser/net/browser_url_util.h (right): http://codereview.chromium.org/9271025/diff/1002/chrome/browser/net/browser_url_util.h#newcode42 chrome/browser/net/browser_url_util.h:42: std::string* out_value); The Style Guide ...
3 years, 6 months ago (2012-01-21 01:42:41 UTC) #4
Evan Stade
rubber stamp lgtm
3 years, 6 months ago (2012-01-21 01:57:34 UTC) #5
xiyuan
http://codereview.chromium.org/9271025/diff/1/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (right): http://codereview.chromium.org/9271025/diff/1/chrome/browser/chromeos/login/login_utils.cc#newcode863 chrome/browser/chromeos/login/login_utils.cc:863: VLOG(1) << "Start fetch oauth1 access token."; On 2012/01/21 ...
3 years, 6 months ago (2012-01-21 16:48:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/9271025/10002
3 years, 6 months ago (2012-01-21 18:37:32 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
3 years, 6 months ago (2012-01-21 19:40:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/9271025/10002
3 years, 6 months ago (2012-01-21 20:14:10 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2012-01-21 22:27:40 UTC) #10
Change committed as 118627
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f