Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 926963003: InlinedVisitor: Migrate animation to use inlined tracing (Closed)

Created:
5 years, 10 months ago by kouhei (in TOK)
Modified:
5 years, 10 months ago
CC:
blink-reviews, shans, rjwright, blink-reviews-style_chromium.org, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

InlinedVisitor: Migrate animation to use inlined tracing Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ R=oilpan-reviews BUG=455524 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190739

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -116 lines) Patch
M Source/core/animation/ActiveAnimations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ActiveAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/Animation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/Animation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationNode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationNodeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationNodeTiming.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationNodeTiming.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationStack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationTimeline.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/AnimationTimeline.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationTimelineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ColorStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ColorStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorPendingAnimations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorPendingAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ConstantStyleInterpolation.h View 1 chunk +1 line, -1 line 1 comment Download
M Source/core/animation/DeferredLegacyStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DeferredLegacyStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DoubleStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DoubleStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ImageStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ImageStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InertAnimation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InertAnimation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InterpolableValue.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/InterpolableValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/Interpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/Interpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/InterpolationEffect.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/InterpolationEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/Keyframe.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/LegacyStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.cpp View 1 chunk +1 line, -1 line 1 comment Download
M Source/core/animation/LengthStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/SVGLengthStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/SampledEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/SampledEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/StringKeyframe.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/StyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/VisibilityStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/VisibilityStyleInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableClipPathOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableColor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableDouble.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableDoubleAndBool.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableFilterOperations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableFilterOperations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableLength.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableLengthBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableLengthBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableLengthBoxAndBool.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableLengthBoxAndBool.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableLengthPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableLengthPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableLengthPoint3D.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableLengthPoint3D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableLengthSize.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableLengthSize.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableNeutral.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableRepeatable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableRepeatable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableSVGLength.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableSVGLength.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableSVGPaint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableShapeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableStrokeDasharrayList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableStrokeDasharrayList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableTransform.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableUnknown.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableValueKeyframe.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValueKeyframe.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableVisibility.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimationUpdate.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kouhei (in TOK)
5 years, 10 months ago (2015-02-24 07:53:11 UTC) #1
tkent
lgtm
5 years, 10 months ago (2015-02-24 08:18:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926963003/1
5 years, 10 months ago (2015-02-24 08:20:48 UTC) #5
haraken
LGTM https://codereview.chromium.org/926963003/diff/1/Source/core/animation/ConstantStyleInterpolation.h File Source/core/animation/ConstantStyleInterpolation.h (right): https://codereview.chromium.org/926963003/diff/1/Source/core/animation/ConstantStyleInterpolation.h#newcode27 Source/core/animation/ConstantStyleInterpolation.h:27: StyleInterpolation::trace(visitor); Make this a tail call. https://codereview.chromium.org/926963003/diff/1/Source/core/animation/LengthBoxStyleInterpolation.cpp File ...
5 years, 10 months ago (2015-02-24 08:56:07 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 10:33:39 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190739

Powered by Google App Engine
This is Rietveld 408576698