Source/core/animation/Keyframe.h - Issue 926963003: InlinedVisitor: Migrate animation to use inlined tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/Keyframe.h

Issue 926963003: InlinedVisitor: Migrate animation to use inlined tracing (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/ConstantStyleInterpolation.h ('K') | « Source/core/animation/InterpolationEffect.cpp ('k') | Source/core/animation/KeyframeEffectModel.h » ('j') | Source/core/animation/LengthBoxStyleInterpolation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/Keyframe.h

diff --git a/Source/core/animation/Keyframe.h b/Source/core/animation/Keyframe.h

index f8a607df01590451f41d924c74d46159c45b5857..ace7dda84292811b87f1a07ac76de854246da68a 100644

--- a/Source/core/animation/Keyframe.h

+++ b/Source/core/animation/Keyframe.h

@@ -48,7 +48,7 @@ public:

virtual bool isAnimatableValueKeyframe() const { return false; }

virtual bool isStringKeyframe() const { return false; }

- virtual void trace(Visitor*) { }

+ DEFINE_INLINE_VIRTUAL_TRACE() { }

class PropertySpecificKeyframe : public NoBaseWillBeGarbageCollectedFinalized<PropertySpecificKeyframe> {

public:

@@ -66,7 +66,7 @@ public:

virtual PassOwnPtrWillBeRawPtr<PropertySpecificKeyframe> neutralKeyframe(double offset, PassRefPtr<TimingFunction> easing) const = 0;

virtual PassRefPtrWillBeRawPtr<Interpolation> maybeCreateInterpolation(CSSPropertyID, blink::Keyframe::PropertySpecificKeyframe& end, Element*) const = 0;

- virtual void trace(Visitor*) { }

+ DEFINE_INLINE_VIRTUAL_TRACE() { }

protected:

PropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, AnimationEffect::CompositeOperation);