Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 926643003: [Android] DeviceUtils: Prefer our unzip implementation. (Closed)

Created:
5 years, 10 months ago by Raphael Kubo da Costa (rakuco)
Modified:
5 years, 10 months ago
Reviewers:
klundberg, jbudorick, Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] DeviceUtils: Prefer our unzip implementation. It is possible that another unzip is installed on a device and ends up being found first in $PATH. This can be problematic when binaries such as device_forwarder need to be re-uploaded, as other unzip implementations tend to loop forever asking whether the existing binary should be overwritten. Instead, put the path to our unzip implementation first so it is always used. BUG=428729, 433101 Committed: https://crrev.com/5e665314585d65be08c273d239baf213365c3e33 Cr-Commit-Position: refs/heads/master@{#316402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/pylib/device/device_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/device/device_utils_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Raphael Kubo da Costa (rakuco)
5 years, 10 months ago (2015-02-13 21:35:50 UTC) #2
jbudorick
lgtm, thanks!
5 years, 10 months ago (2015-02-14 00:41:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926643003/1
5 years, 10 months ago (2015-02-14 14:36:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/59371)
5 years, 10 months ago (2015-02-14 14:49:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926643003/1
5 years, 10 months ago (2015-02-14 14:55:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/59377)
5 years, 10 months ago (2015-02-14 15:04:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926643003/1
5 years, 10 months ago (2015-02-14 22:12:22 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 22:40:26 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 22:41:00 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e665314585d65be08c273d239baf213365c3e33
Cr-Commit-Position: refs/heads/master@{#316402}

Powered by Google App Engine
This is Rietveld 408576698