build/android/pylib/device/device_utils.py - Issue 926643003: [Android] DeviceUtils: Prefer our unzip implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/device/device_utils.py

Issue 926643003: [Android] DeviceUtils: Prefer our unzip implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/device/device_utils.py

diff --git a/build/android/pylib/device/device_utils.py b/build/android/pylib/device/device_utils.py

index a1b4117f7b963887e8516526ec0fc878ba5c1c8a..e3387e48224da75cc121cc8f11a8bd7f86fe982a 100644

--- a/build/android/pylib/device/device_utils.py

+++ b/build/android/pylib/device/device_utils.py

@@ -847,7 +847,7 @@ class DeviceUtils(object):

self.RunShellCommand(

['unzip', zip_on_device],

as_root=True,

- env={'PATH': '$PATH:%s' % install_commands.BIN_DIR},

+ env={'PATH': '%s:$PATH' % install_commands.BIN_DIR},

check_return=True)

finally:

if zip_proc.is_alive():

« no previous file with comments | « no previous file | build/android/pylib/device/device_utils_test.py » ('j') | no next file with comments »