Push API: UMA logs of whether SWs show notifications when required

Push API: UMA logs of whether SWs show notifications when required

We'll use these to monitor whether users are getting spammed.

BUG=401438
Committed: https://crrev.com/90b506b0bfab273a643cbd9f414180d8c724a0b1
Cr-Commit-Position: refs/heads/master@{#316363}

[johnme, 2015-02-13 11:25:57]

johnme@chromium.org changed reviewers:
+ avi@chromium.org, isherman@chromium.org, mvanouwerkerk@chromium.org

[johnme, 2015-02-13 11:25:58]

mvanouwerkerk@chromium.org: Please review overall patch, especially
chrome/browser/services/gcm/push_messaging_service_impl.cc

avi@chromium.org: Please review changes in
content/public/common/push_messaging_status.h

isherman@chromium.org: Please review changes in
tools/metrics/histograms/histograms.xml

Thanks all!

[Miguel Garcia, 2015-02-13 11:26:25]

miguelg@chromium.org changed reviewers:
+ miguelg@chromium.org

[Miguel Garcia, 2015-02-13 11:26:25]

https://codereview.chromium.org/926583002/diff/1/content/public/common/push_m...
File content/public/common/push_messaging_status.h (right):

https://codereview.chromium.org/926583002/diff/1/content/public/common/push_m...
content/public/common/push_messaging_status.h:127: 
can we have a explicit UMA for "The default notification was shown". Maybe not
in this enum but as an independent counter.

[Michael van Ouwerkerk, 2015-02-13 11:33:09]

lgtm

[johnme, 2015-02-13 18:35:59]

New patchsets have been uploaded after l-g-t-m from mvanouwerkerk@chromium.org

[johnme, 2015-02-13 18:36:26]

https://codereview.chromium.org/926583002/diff/1/content/public/common/push_m...
File content/public/common/push_messaging_status.h (right):

https://codereview.chromium.org/926583002/diff/1/content/public/common/push_m...
content/public/common/push_messaging_status.h:127: 
On 2015/02/13 11:26:25, Miguel Garcia wrote:
> can we have a explicit UMA for "The default notification was shown". Maybe not
> in this enum but as an independent counter.

Yes, that's precisely what
PUSH_USER_VISIBLE_STATUS_REQUIRED_BUT_NOT_SHOWN_GRACE_EXCEEDED does. My comment
was unclear; I've updated the comment.

[johnme, 2015-02-13 22:13:49]

johnme@chromium.org changed reviewers:
- isherman@chromium.org

[Alexei Svitkine (slow), 2015-02-13 22:17:28]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-02-13 22:17:28]

lgtm

[Charlie Reis, 2015-02-13 23:04:02]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2015-02-13 23:04:03]

content/public LGTM.

[johnme, 2015-02-14 01:28:27]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2015-02-14 01:29:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/926583002/20001

[johnme, 2015-02-14 01:49:03]

johnme@chromium.org changed reviewers:
- avi@chromium.org

[commit-bot: I haz the power, 2015-02-14 02:23:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-14 02:24:21]

Patchset 2 (id:??) landed as
https://crrev.com/90b506b0bfab273a643cbd9f414180d8c724a0b1
Cr-Commit-Position: refs/heads/master@{#316363}

[no sievers, 2015-02-17 20:26:56]

sievers@chromium.org changed reviewers:
+ sievers@chromium.org

[no sievers, 2015-02-17 20:26:57]

lgtm

https://codereview.chromium.org/926583002/diff/20001/content/public/common/pu...
File content/public/common/push_messaging_status.h (right):

https://codereview.chromium.org/926583002/diff/20001/content/public/common/pu...
content/public/common/push_messaging_status.h:112: enum PushUserVisibleStatus {
Hmm ok, it was already like this, but 
http://www.chromium.org/developers/content-module/content-api says that each
enum should be in its own file.