Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: content/public/common/push_messaging_status.h

Issue 926583002: Push API: UMA logs of whether SWs show notifications when required (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ifdef_brackets
Patch Set: Comment tweaks Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/services/gcm/push_messaging_service_impl.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/push_messaging_status.h
diff --git a/content/public/common/push_messaging_status.h b/content/public/common/push_messaging_status.h
index 21dcc6b22285fc1bdf1b7fbe2ddaf70edf55dc67..b59ead91a8872885a8c259d4b4c85f6f04f24d95 100644
--- a/content/public/common/push_messaging_status.h
+++ b/content/public/common/push_messaging_status.h
@@ -108,6 +108,35 @@ enum PushDeliveryStatus {
PUSH_DELIVERY_STATUS_LAST = PUSH_DELIVERY_STATUS_EVENT_WAITUNTIL_REJECTED
};
+// Push message user visible tracking for reporting in UMA.
+enum PushUserVisibleStatus {
no sievers 2015/02/17 20:26:56 Hmm ok, it was already like this, but http://www.
+ // A notification was required and one (or more) were shown.
+ PUSH_USER_VISIBLE_STATUS_REQUIRED_AND_SHOWN = 0,
+
+ // A notification was not required, but one (or more) were shown anyway.
+ PUSH_USER_VISIBLE_STATUS_NOT_REQUIRED_BUT_SHOWN = 1,
+
+ // A notification was not required and none were shown.
+ PUSH_USER_VISIBLE_STATUS_NOT_REQUIRED_AND_NOT_SHOWN = 2,
+
+ // A notification was required, but none were shown. Fortunately, the site has
+ // been well behaved recently so it was glossed over.
+ PUSH_USER_VISIBLE_STATUS_REQUIRED_BUT_NOT_SHOWN_USED_GRACE = 3,
+
+ // A notification was required, but none were shown. Unfortunately, the site
+ // has run out of grace, so we had to show the user a generic notification.
+ PUSH_USER_VISIBLE_STATUS_REQUIRED_BUT_NOT_SHOWN_GRACE_EXCEEDED = 4,
+
+ // NOTE: Do not renumber these as that would confuse interpretation of
+ // previously logged data. When making changes, also update the enum list
+ // in tools/metrics/histograms/histograms.xml to keep it in sync, and
+ // update PUSH_USER_VISIBLE_STATUS_LAST below.
+
+ // Used for IPC message range checks.
+ PUSH_USER_VISIBLE_STATUS_LAST =
+ PUSH_USER_VISIBLE_STATUS_REQUIRED_BUT_NOT_SHOWN_GRACE_EXCEEDED
+};
+
const char* PushRegistrationStatusToString(PushRegistrationStatus status);
} // namespace content
« no previous file with comments | « chrome/browser/services/gcm/push_messaging_service_impl.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698