Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 926123002: Revert of YUV scale fix (Closed)

Created:
5 years, 10 months ago by jvanverth1
Modified:
5 years, 10 months ago
Reviewers:
sugoi1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of YUV scale fix (patchset #2 id:20001 of https://codereview.chromium.org/922273002/) Reason for revert: Turning Windows compile bots red. Original issue's description: > YUV scale fix > > There was a scaling mistake visible in some JPEG images because the ratio between Y, U and V planes were assumed to be the same ratios as the ratio between texture sizes, which was wrong because texture have a minimum size of 16 and are rounded up to the next POT. Since the ratios between Y and UV planes are generally 1, 2 or 4, rounding up to the next POT would generally preserve this ratio, so that this bug was not very visible, apart from very small jpeg images of 8 or less pixels in either width or height. > > BUG=457954 > > Committed: https://skia.googlesource.com/skia/+/e6eddf7dd85add7da41f22f2643bdd573ad1f1cf TBR=bsalomon@google.com,sugoi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457954 Committed: https://skia.googlesource.com/skia/+/0ff748ace6a53f05b52268f7a8786eeef611a839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -53 lines) Patch
M gm/yuvtorgbeffect.cpp View 5 chunks +11 lines, -20 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 5 chunks +12 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jvanverth1
Created Revert of YUV scale fix
5 years, 10 months ago (2015-02-13 20:02:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926123002/1
5 years, 10 months ago (2015-02-13 20:02:16 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 20:02:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0ff748ace6a53f05b52268f7a8786eeef611a839

Powered by Google App Engine
This is Rietveld 408576698