Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Issue 926083002: Decouple web_view.js from attribute internals (Closed)

Created:
5 years, 10 months ago by Fady Samuel
Modified:
5 years, 10 months ago
Reviewers:
paulmeyer
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ignore_mutation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Decouple web_view.js from attribute internals Hide implementation details of <webview> attribute state from web_view.js. We introduce a reset method on methods to be called in onElementDetached that resets the internal state without exposing the details of what that internal state is. BUG=none TBR=lazyboy@chromium.org Committed: https://crrev.com/09efc6216740c28452cc244cff18d8c33c091239 Cr-Commit-Position: refs/heads/master@{#316294}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M extensions/renderer/resources/guest_view/web_view.js View 2 chunks +3 lines, -5 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_attributes.js View 5 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Fady Samuel
5 years, 10 months ago (2015-02-13 17:46:01 UTC) #2
paulmeyer
LGTM! This is definitely a better way to handle those flags.
5 years, 10 months ago (2015-02-13 18:27:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926083002/20001
5 years, 10 months ago (2015-02-13 20:35:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 21:34:05 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 21:35:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09efc6216740c28452cc244cff18d8c33c091239
Cr-Commit-Position: refs/heads/master@{#316294}

Powered by Google App Engine
This is Rietveld 408576698