Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: extensions/renderer/resources/guest_view/web_view.js

Issue 926083002: Decouple web_view.js from attribute internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ignore_mutation
Patch Set: Rebased Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/resources/guest_view/web_view_attributes.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/guest_view/web_view.js
diff --git a/extensions/renderer/resources/guest_view/web_view.js b/extensions/renderer/resources/guest_view/web_view.js
index e5fc2702b69aecc5ef6057b372790c43ef3cc1a4..32f99f1ac59789a9a57203a4f8e2dd6431c89ea2 100644
--- a/extensions/renderer/resources/guest_view/web_view.js
+++ b/extensions/renderer/resources/guest_view/web_view.js
@@ -17,8 +17,6 @@ var WebViewInternal = require('webViewInternal').WebViewInternal;
function WebViewImpl(webviewElement) {
GuestViewContainer.call(this, webviewElement, 'webview');
- this.beforeFirstNavigation = true;
-
this.setupWebViewAttributes();
this.setupElementProperties();
@@ -71,9 +69,9 @@ WebViewImpl.prototype.onElementAttached = function() {
// Resets some state upon detaching <webview> element from the DOM.
WebViewImpl.prototype.onElementDetached = function() {
this.guest.destroy();
- this.beforeFirstNavigation = true;
- this.attributes[WebViewConstants.ATTRIBUTE_PARTITION].validPartitionId =
- true;
+ for (var i in this.attributes) {
+ this.attributes[i].reset();
+ }
};
// Sets the <webview>.request property.
« no previous file with comments | « no previous file | extensions/renderer/resources/guest_view/web_view_attributes.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698