Clean up some strings.

Clean up some strings.

- Moves some strings from android_ui_strings.grd to
  android_chrome_strings.grd since they're only used in src/chrome
- Simplifies string loading and formatting in Data Saver promo
- Uses Android's Formatter class to format byte/KB/MB values instead of
  rolling our own solution in WebsitePreference.java.
- Neatens up android_ui_strings.grd

Committed: https://crrev.com/a3d81701bb7d2c162ccf85529d602ed3e4a0a258
Cr-Commit-Position: refs/heads/master@{#316282}

[newt (away), 2015-02-13 19:43:15]

newt@chromium.org changed reviewers:
+ aurimas@chromium.org

[newt (away), 2015-02-13 19:43:16]

PTAL

https://codereview.chromium.org/926033003/diff/1/ui/android/java/strings/andr...
File ui/android/java/strings/android_ui_strings.grd (right):

https://codereview.chromium.org/926033003/diff/1/ui/android/java/strings/andr...
ui/android/java/strings/android_ui_strings.grd:96: <!-- Select file dialog -->
codereview doesn't show the changes in this file very clearly. I removed the
"generic strings" section, added section titles for the other strings, and moved
the name attribute before the desc for each string (except the autofill wallet
strings which are being removed from this file by another CL)

[aurimas (slooooooooow), 2015-02-13 19:48:33]

lgtm

https://codereview.chromium.org/926033003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
(right):

https://codereview.chromium.org/926033003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:76:
Formatter.formatShortFileSize(context, usage)));
Yay for simplifying :)

https://codereview.chromium.org/926033003/diff/1/ui/android/java/strings/andr...
File ui/android/java/strings/android_ui_strings.grd (right):

https://codereview.chromium.org/926033003/diff/1/ui/android/java/strings/andr...
ui/android/java/strings/android_ui_strings.grd:96: <!-- Select file dialog -->
On 2015/02/13 at 19:43:16, newt wrote:
> codereview doesn't show the changes in this file very clearly. I removed the
"generic strings" section, added section titles for the other strings, and moved
the name attribute before the desc for each string (except the autofill wallet
strings which are being removed from this file by another CL)

I'll just assume you did a good job here haha.

[newt (away), 2015-02-13 19:53:34]

New patchsets have been uploaded after l-g-t-m from aurimas@chromium.org

[newt (away), 2015-02-13 19:53:41]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-02-13 19:54:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/926033003/20001

[commit-bot: I haz the power, 2015-02-13 20:44:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-13 20:45:25]

Patchset 2 (id:??) landed as
https://crrev.com/a3d81701bb7d2c162ccf85529d602ed3e4a0a258
Cr-Commit-Position: refs/heads/master@{#316282}