pkg/compiler/lib/src/io/code_output.dart - Issue 925943002: Refactor SourceFile, SourceFileProvider and SourceLocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/io/code_output.dart

Issue 925943002: Refactor SourceFile, SourceFileProvider and SourceLocation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/dart2js.dart ('K') | « pkg/compiler/lib/src/dart2js.dart ('k') | pkg/compiler/lib/src/io/source_file.dart » ('j') | pkg/compiler/lib/src/io/source_map_builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/io/code_output.dart

diff --git a/pkg/compiler/lib/src/io/code_output.dart b/pkg/compiler/lib/src/io/code_output.dart

index 5f131987eb33309218426bc141f985c77694f02f..d046f2242a50025c403984b68cae5d28e98e2c60 100644

--- a/pkg/compiler/lib/src/io/code_output.dart

+++ b/pkg/compiler/lib/src/io/code_output.dart

@@ -10,7 +10,7 @@ import 'source_information.dart';

class CodeOutputMarker {

final int offsetDelta;

- final SourceFileLocation sourcePosition;

+ final SourceLocation sourcePosition;

CodeOutputMarker(this.offsetDelta, this.sourcePosition);

}

@@ -43,7 +43,7 @@ abstract class CodeOutput {

/// Applies [f] to every marker in this output.

void forEachSourceLocation(void f(int targetOffset,

- SourceFileLocation sourceLocation));

+ SourceLocation sourceLocation));

}

abstract class AbstractCodeOutput extends CodeOutput {

@@ -91,7 +91,7 @@ abstract class AbstractCodeOutput extends CodeOutput {

--mappedRangeCounter;

}

- void setSourceLocation(SourceFileLocation sourcePosition) {

+ void setSourceLocation(SourceLocation sourcePosition) {

if (sourcePosition == null) {

if (markers.length > 0 && markers.last.sourcePosition == null) return;

}

« pkg/compiler/lib/src/dart2js.dart ('K') | « pkg/compiler/lib/src/dart2js.dart ('k') | pkg/compiler/lib/src/io/source_file.dart » ('j') | pkg/compiler/lib/src/io/source_map_builder.dart » ('J')