pkg/compiler/lib/src/dart2js.dart - Issue 925943002: Refactor SourceFile, SourceFileProvider and SourceLocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/dart2js.dart

Issue 925943002: Refactor SourceFile, SourceFileProvider and SourceLocation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/dart2js.dart

diff --git a/pkg/compiler/lib/src/dart2js.dart b/pkg/compiler/lib/src/dart2js.dart

index 1fbf54358fbbd205d5da824aab4b9db87a77ea37..0fb9b23382cc462c798ccfddf5d60f92550b23fe 100644

--- a/pkg/compiler/lib/src/dart2js.dart

+++ b/pkg/compiler/lib/src/dart2js.dart

@@ -169,8 +169,8 @@ Future<api.CompilationResult> compile(List<String> argv) {

passThrough(argument);

}

- String getDepsOutput(Map<String, SourceFile> sourceFiles) {

- var filenames = new List.from(sourceFiles.keys);

+ String getDepsOutput(Map<Uri, SourceFile> sourceFiles) {

+ var filenames = new List.from(sourceFiles.keys.map((uri) => '$uri'));

floitsch 2015/02/13 13:46:03 since you don't use the generic argument from List

Johnni Winther 2015/02/13 13:55:49 Done.

filenames.sort();

return filenames.join("\n");

}

« no previous file with comments | « pkg/compiler/lib/src/apiimpl.dart ('k') | pkg/compiler/lib/src/io/code_output.dart » ('j') | pkg/compiler/lib/src/io/source_map_builder.dart » ('J')