Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 925933004: Prune HitTestResult and stop special-casing links. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Prune HitTestResult and stop special-casing links. Prunes a bunch of dead code from HitTestResult and stops special-casing links for creating hand cursors. This code already isn't working today anyways, so in practice, there's no change in behavior. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/11d1a3f7e201e0210ac80d0cc1ff68677edfac30

Patch Set 1 #

Total comments: 1

Patch Set 2 : address review comments #

Patch Set 3 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -359 lines) Patch
M sky/engine/core/page/EventHandler.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 1 2 4 chunks +7 lines, -19 lines 0 comments Download
M sky/engine/core/rendering/HitTestResult.h View 4 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/rendering/HitTestResult.cpp View 7 chunks +0 lines, -69 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/public/web/WebHitTestResult.h View 1 chunk +0 lines, -83 lines 0 comments Download
M sky/engine/public/web/WebView.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/public/web/WebViewClient.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/engine/web/WebHitTestResult.cpp View 1 chunk +0 lines, -134 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ojan
5 years, 10 months ago (2015-02-13 22:11:57 UTC) #2
esprehn
lgtm https://codereview.chromium.org/925933004/diff/1/sky/engine/core/page/EventHandler.cpp File sky/engine/core/page/EventHandler.cpp (right): https://codereview.chromium.org/925933004/diff/1/sky/engine/core/page/EventHandler.cpp#newcode370 sky/engine/core/page/EventHandler.cpp:370: if ((node && node->hasEditableStyle()) || (renderer && renderer->isText() ...
5 years, 10 months ago (2015-02-13 22:13:13 UTC) #3
ojan
5 years, 10 months ago (2015-02-13 22:17:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
11d1a3f7e201e0210ac80d0cc1ff68677edfac30 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698