Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: sky/engine/core/rendering/HitTestResult.h

Issue 925933004: Prune HitTestResult and stop special-casing links. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: address review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/page/EventHandler.cpp ('k') | sky/engine/core/rendering/HitTestResult.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/HitTestResult.h
diff --git a/sky/engine/core/rendering/HitTestResult.h b/sky/engine/core/rendering/HitTestResult.h
index 803b03dd12b120bb71a85e5ba482435ef21e99fe..26319eab19d219884c3d085772b49bb40c4020d3 100644
--- a/sky/engine/core/rendering/HitTestResult.h
+++ b/sky/engine/core/rendering/HitTestResult.h
@@ -66,7 +66,6 @@ public:
Node* innerPossiblyPseudoNode() const { return m_innerPossiblyPseudoNode.get(); }
Element* innerElement() const;
Node* innerNonSharedNode() const { return m_innerNonSharedNode.get(); }
- Element* URLElement() const { return m_innerURLElement.get(); }
bool isOverWidget() const { return m_isOverWidget; }
// Forwarded from HitTestLocation
@@ -92,23 +91,13 @@ public:
void setInnerNode(Node*);
void setInnerNonSharedNode(Node*);
- void setURLElement(Element*);
- void setIsOverWidget(bool b) { m_isOverWidget = b; }
bool isSelected() const;
Image* image() const;
IntRect imageRect() const;
- KURL absoluteImageURL() const;
- // This variant of absoluteImageURL will also convert <canvas> elements
- // to huge image data URLs (very expensive).
- KURL absoluteImageURLIncludingCanvasDataURL() const;
- KURL absoluteLinkURL() const;
- String textContent() const;
- bool isLiveLink() const;
bool isMisspelled() const;
bool isContentEditable() const;
- bool isOverLink() const;
// Returns true if it is rect-based hit test and needs to continue until the rect is fully
// enclosed by the boundaries of a node.
bool addNodeToRectBasedTestResult(Node*, const HitTestRequest&, const HitTestLocation& pointInContainer, const LayoutRect& = LayoutRect());
@@ -127,7 +116,6 @@ public:
Node* targetNode() const { return innerNode(); }
private:
- KURL absoluteImageURLInternal(bool allowCanvas) const;
NodeSet& mutableRectBasedTestResult(); // See above.
HitTestLocation m_hitTestLocation;
@@ -139,7 +127,6 @@ private:
LayoutPoint m_pointInInnerNodeFrame; // The hit-tested point in innerNode frame coordinates.
LayoutPoint m_localPoint; // A point in the local coordinate space of m_innerNonSharedNode's renderer. Allows us to efficiently
// determine where inside the renderer we hit on subsequent operations.
- RefPtr<Element> m_innerURLElement;
bool m_isOverWidget; // Returns true if we are over a widget.
mutable OwnPtr<NodeSet> m_rectBasedTestResult;
« no previous file with comments | « sky/engine/core/page/EventHandler.cpp ('k') | sky/engine/core/rendering/HitTestResult.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698