Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 925903002: Disable elastic overscroll effect in DevTools. (Closed)

Created:
5 years, 10 months ago by dgozman
Modified:
5 years, 10 months ago
Reviewers:
pfeldman, ccameron
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable elastic overscroll effect in DevTools. BUG=456546 Committed: https://crrev.com/5210d618e08fc4a1ce3ab0953d7fa42a98fc8140 Cr-Commit-Position: refs/heads/master@{#316834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M content/browser/devtools/devtools_frontend_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/devtools_frontend_host_impl.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
dgozman
Take a look please. @ccameron: this is how I plan to disable elastic overscroll in ...
5 years, 10 months ago (2015-02-13 10:24:17 UTC) #2
pfeldman
We need to merge the fix into M41 (or rollback offending patch there). I am ...
5 years, 10 months ago (2015-02-14 16:22:01 UTC) #3
ccameron
On 2015/02/14 16:22:01, pfeldman wrote: > We need to merge the fix into M41 (or ...
5 years, 10 months ago (2015-02-17 19:40:16 UTC) #4
pfeldman
lgtm
5 years, 10 months ago (2015-02-18 15:13:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925903002/1
5 years, 10 months ago (2015-02-18 15:14:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 16:03:01 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5210d618e08fc4a1ce3ab0953d7fa42a98fc8140 Cr-Commit-Position: refs/heads/master@{#316834}
5 years, 10 months ago (2015-02-18 16:03:34 UTC) #9
dgozman
5 years, 9 months ago (2015-02-27 13:12:00 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/963743003/ by dgozman@chromium.org.

The reason for reverting is: Turned out this patch is unnecessary..

Powered by Google App Engine
This is Rietveld 408576698