Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: extensions/utility/unpacker.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_test.cc ('k') | google_apis/drive/test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/utility/unpacker.cc
diff --git a/extensions/utility/unpacker.cc b/extensions/utility/unpacker.cc
index d244ba5840b686a851a5959f66bfe87ffccc06cf..c61faa24f53e749d570ae5f0b5b701e1cbd6da02 100644
--- a/extensions/utility/unpacker.cc
+++ b/extensions/utility/unpacker.cc
@@ -118,9 +118,9 @@ base::DictionaryValue* Unpacker::ReadManifest() {
return NULL;
}
- JSONFileValueSerializer serializer(manifest_path);
+ JSONFileValueDeserializer deserializer(manifest_path);
std::string error;
- scoped_ptr<base::Value> root(serializer.Deserialize(NULL, &error));
+ scoped_ptr<base::Value> root(deserializer.Deserialize(NULL, &error));
if (!root.get()) {
SetError(error);
return NULL;
@@ -270,9 +270,9 @@ bool Unpacker::AddDecodedImage(const base::FilePath& path) {
bool Unpacker::ReadMessageCatalog(const base::FilePath& message_path) {
std::string error;
- JSONFileValueSerializer serializer(message_path);
+ JSONFileValueDeserializer deserializer(message_path);
scoped_ptr<base::DictionaryValue> root(static_cast<base::DictionaryValue*>(
- serializer.Deserialize(NULL, &error)));
+ deserializer.Deserialize(NULL, &error)));
if (!root.get()) {
base::string16 messages_file = message_path.LossyDisplayName();
if (error.empty()) {
« no previous file with comments | « extensions/common/manifest_test.cc ('k') | google_apis/drive/test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698