extensions/common/manifest_test.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_test.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/manifest_test.cc

diff --git a/extensions/common/manifest_test.cc b/extensions/common/manifest_test.cc

index 14e0aef0a0f8b0d7f9ef0d7e92d526f7c63671fd..a3712d07d4a66454981d3277f5610b44ec778641 100644

--- a/extensions/common/manifest_test.cc

+++ b/extensions/common/manifest_test.cc

@@ -26,9 +26,9 @@ base::DictionaryValue* LoadManifestFile(const base::FilePath& manifest_path,

EXPECT_TRUE(base::PathExists(manifest_path)) <<

"Couldn't find " << manifest_path.value();

- JSONFileValueSerializer serializer(manifest_path);

- base::DictionaryValue* manifest =

- static_cast<base::DictionaryValue*>(serializer.Deserialize(NULL, error));

+ JSONFileValueDeserializer deserializer(manifest_path);

+ base::DictionaryValue* manifest = static_cast<base::DictionaryValue*>(

+ deserializer.Deserialize(NULL, error));

// Most unit tests don't need localization, and they'll fail if we try to

// localize them, since their manifests don't have a default_locale key.

« no previous file with comments | « extensions/common/file_util_unittest.cc ('k') | extensions/utility/unpacker.cc » ('j') | no next file with comments »