extensions/browser/api/printer_provider/printer_provider_apitest.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/printer_provider/printer_provider_apitest.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/printer_provider/printer_provider_api.cc ('k') | extensions/browser/extension_icon_image_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/printer_provider/printer_provider_apitest.cc

diff --git a/extensions/browser/api/printer_provider/printer_provider_apitest.cc b/extensions/browser/api/printer_provider/printer_provider_apitest.cc

index 0a4662a4d58d7af761e64a07e5cfa7499091eb22..84e47f70066884d01eee542cf99be15b241cc85b 100644

--- a/extensions/browser/api/printer_provider/printer_provider_apitest.cc

+++ b/extensions/browser/api/printer_provider/printer_provider_apitest.cc

@@ -212,10 +212,10 @@ class PrinterProviderApiTest : public extensions::ShellApiTest {

const std::vector<std::string>& expected_printers) {

ASSERT_EQ(expected_printers.size(), printers.GetSize());

for (size_t i = 0; i < expected_printers.size(); ++i) {

- JSONStringValueSerializer serializer(expected_printers[i]);

+ JSONStringValueDeserializer deserializer(expected_printers[i]);

int error_code;

scoped_ptr<base::Value> printer_value(

- serializer.Deserialize(&error_code, NULL));

+ deserializer.Deserialize(&error_code, NULL));

ASSERT_TRUE(printer_value) << "Failed to deserialize "

<< expected_printers[i] << ": "

<< "error code " << error_code;