extensions/browser/api/printer_provider/printer_provider_api.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/printer_provider/printer_provider_api.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/update_client/component_unpacker.cc ('k') | extensions/browser/api/printer_provider/printer_provider_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/printer_provider/printer_provider_api.cc

diff --git a/extensions/browser/api/printer_provider/printer_provider_api.cc b/extensions/browser/api/printer_provider/printer_provider_api.cc

index a74838d172bf70b1880df74c4cbe83f3bc0209c7..9074942018c39cfd2afdb9997ea802f836d18b7d 100644

--- a/extensions/browser/api/printer_provider/printer_provider_api.cc

+++ b/extensions/browser/api/printer_provider/printer_provider_api.cc

@@ -471,8 +471,8 @@ void PrinterProviderAPIImpl::DispatchPrintRequested(

core_api::printer_provider::PrintJob print_job;

print_job.printer_id = internal_printer_id;

- JSONStringValueSerializer serializer(job.ticket_json);

- scoped_ptr<base::Value> ticket_value(serializer.Deserialize(NULL, NULL));

+ JSONStringValueDeserializer deserializer(job.ticket_json);

+ scoped_ptr<base::Value> ticket_value(deserializer.Deserialize(NULL, NULL));

if (!ticket_value ||

!core_api::printer_provider::PrintJob::Ticket::Populate(

*ticket_value, &print_job.ticket)) {