chrome/common/extensions/extension_test_util.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_test_util.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc ('k') | chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_test_util.cc

diff --git a/chrome/common/extensions/extension_test_util.cc b/chrome/common/extensions/extension_test_util.cc

index e30dd15a8a54b08ce0f696d42b17691882f712fd..ec223f6054631e16dc695c179ffcf6d5ad6e92b7 100644

--- a/chrome/common/extensions/extension_test_util.cc

+++ b/chrome/common/extensions/extension_test_util.cc

@@ -30,8 +30,8 @@ scoped_refptr<Extension> LoadManifestUnchecked(const std::string& dir,

.AppendASCII(dir)

.AppendASCII(test_file);

- JSONFileValueSerializer serializer(path);

- scoped_ptr<base::Value> result(serializer.Deserialize(NULL, error));

+ JSONFileValueDeserializer deserializer(path);

+ scoped_ptr<base::Value> result(deserializer.Deserialize(NULL, error));

if (!result)

return NULL;

const base::DictionaryValue* dict;