chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/extension_test_util.cc ('k') | chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

diff --git a/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc b/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

index 9d60a6354b8fc4edc0bc47ac6184a6e7b96f2967..82bda5adb10381a5290ab0fd43624420f9e34e7a 100644

--- a/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

+++ b/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

@@ -74,7 +74,7 @@ class OverrideSettingsTest : public testing::Test {

TEST_F(OverrideSettingsTest, ParseManifest) {

std::string manifest(kManifest);

- JSONStringValueSerializer json(&manifest);

+ JSONStringValueDeserializer json(manifest);

std::string error;

scoped_ptr<base::Value> root(json.Deserialize(NULL, &error));

ASSERT_TRUE(root);

@@ -117,7 +117,7 @@ TEST_F(OverrideSettingsTest, ParseManifest) {

TEST_F(OverrideSettingsTest, ParsePrepopulatedId) {

std::string manifest(kPrepopulatedManifest);

- JSONStringValueSerializer json(&manifest);

+ JSONStringValueDeserializer json(manifest);

std::string error;

scoped_ptr<base::Value> root(json.Deserialize(NULL, &error));

ASSERT_TRUE(root);

@@ -150,7 +150,7 @@ TEST_F(OverrideSettingsTest, ParsePrepopulatedId) {

TEST_F(OverrideSettingsTest, ParseBrokenManifest) {

std::string manifest(kBrokenManifest);

- JSONStringValueSerializer json(&manifest);

+ JSONStringValueDeserializer json(manifest);

std::string error;

scoped_ptr<base::Value> root(json.Deserialize(NULL, &error));

ASSERT_TRUE(root);