Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1559)

Unified Diff: chrome/browser/extensions/extension_action_icon_factory_unittest.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action_icon_factory_unittest.cc
diff --git a/chrome/browser/extensions/extension_action_icon_factory_unittest.cc b/chrome/browser/extensions/extension_action_icon_factory_unittest.cc
index 4292ed419a0fef4ce8a034ea07710e606ab251b2..3d45e15b1aa95fc362942131bedd945d12352751 100644
--- a/chrome/browser/extensions/extension_action_icon_factory_unittest.cc
+++ b/chrome/browser/extensions/extension_action_icon_factory_unittest.cc
@@ -107,10 +107,12 @@ class ExtensionActionIconFactoryTest
test_file = test_file.AppendASCII("extensions/api_test").AppendASCII(name);
int error_code = 0;
std::string error;
- JSONFileValueSerializer serializer(test_file.AppendASCII("manifest.json"));
+ JSONFileValueDeserializer deserializer(
+ test_file.AppendASCII("manifest.json"));
scoped_ptr<base::DictionaryValue> valid_value(
- static_cast<base::DictionaryValue*>(serializer.Deserialize(&error_code,
- &error)));
+ static_cast<base::DictionaryValue*>(
+ deserializer.Deserialize(&error_code,
+ &error)));
EXPECT_EQ(0, error_code) << error;
if (error_code != 0)
return NULL;
« no previous file with comments | « chrome/browser/extensions/component_loader.cc ('k') | chrome/browser/extensions/extension_icon_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698