chrome/browser/extensions/extension_icon_manager_unittest.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_icon_manager_unittest.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_action_icon_factory_unittest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_icon_manager_unittest.cc

diff --git a/chrome/browser/extensions/extension_icon_manager_unittest.cc b/chrome/browser/extensions/extension_icon_manager_unittest.cc

index 36dbf5a657172888a1bc1dcc4479bc5d0c4574e1..004c1964fa013393d050cbb418336ee0e3094233 100644

--- a/chrome/browser/extensions/extension_icon_manager_unittest.cc

+++ b/chrome/browser/extensions/extension_icon_manager_unittest.cc

@@ -108,9 +108,10 @@ TEST_F(ExtensionIconManagerTest, LoadRemoveLoad) {

base::FilePath manifest_path = test_dir.AppendASCII(

"extensions/image_loading_tracker/app.json");

- JSONFileValueSerializer serializer(manifest_path);

+ JSONFileValueDeserializer deserializer(manifest_path);

scoped_ptr<base::DictionaryValue> manifest(

- static_cast<base::DictionaryValue*>(serializer.Deserialize(NULL, NULL)));

+ static_cast<base::DictionaryValue*>(deserializer.Deserialize(NULL,

+ NULL)));

ASSERT_TRUE(manifest.get() != NULL);

std::string error;

@@ -150,9 +151,10 @@ TEST_F(ExtensionIconManagerTest, LoadComponentExtensionResource) {