chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc

diff --git a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc

index 536662045d69035a7c48d86e6e85e98b6a492053..8479b13efabe4ef3f1ded390c41a2b2e9a92dd28 100644

--- a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc

+++ b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc

@@ -43,8 +43,8 @@ scoped_ptr<NativeMessagingHostManifest> NativeMessagingHostManifest::Load(

std::string* error_message) {

DCHECK(error_message);

- JSONFileValueSerializer serializer(file_path);

- scoped_ptr<base::Value> parsed(serializer.Deserialize(NULL, error_message));

+ JSONFileValueDeserializer deserializer(file_path);

+ scoped_ptr<base::Value> parsed(deserializer.Deserialize(NULL, error_message));

if (!parsed) {

return scoped_ptr<NativeMessagingHostManifest>();

}

« no previous file with comments | « chrome/browser/drive/fake_drive_service.cc ('k') | chrome/browser/extensions/chrome_info_map_unittest.cc » ('j') | no next file with comments »