chrome/browser/drive/fake_drive_service.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/drive/fake_drive_service.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/diagnostics/recon_diagnostics.cc ('k') | chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/drive/fake_drive_service.cc

diff --git a/chrome/browser/drive/fake_drive_service.cc b/chrome/browser/drive/fake_drive_service.cc

index f34c0d62684a84a5a25b10e86618374e8f8a30c1..7f9b585b9f309ec8bda151115ce10ca342599c10 100644

--- a/chrome/browser/drive/fake_drive_service.cc

+++ b/chrome/browser/drive/fake_drive_service.cc

@@ -280,7 +280,7 @@ void FakeDriveService::AddApp(const std::string& app_id,

ReplaceSubstringsAfterOffset(

&app_json, 0, "$Removable", is_removable ? "true" : "false");

- JSONStringValueSerializer json(app_json);

+ JSONStringValueDeserializer json(app_json);

std::string error_message;

scoped_ptr<base::Value> value(json.Deserialize(NULL, &error_message));

CHECK_EQ(base::Value::TYPE_DICTIONARY, value->GetType());