chrome/browser/diagnostics/recon_diagnostics.cc - Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/diagnostics/recon_diagnostics.cc

Issue 925783002: Split ValueSerializer into separate Serializer and Deserializer classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cpplint warnings. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/test/component_installers_unittest.cc ('k') | chrome/browser/drive/fake_drive_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/diagnostics/recon_diagnostics.cc

diff --git a/chrome/browser/diagnostics/recon_diagnostics.cc b/chrome/browser/diagnostics/recon_diagnostics.cc

index 7b09d865edad7318610cf19b24a081ecb1a97da5..a0575db565540afe98eb5c1548d41f917988dfb7 100644

--- a/chrome/browser/diagnostics/recon_diagnostics.cc

+++ b/chrome/browser/diagnostics/recon_diagnostics.cc

@@ -210,7 +210,7 @@ class JSONTest : public DiagnosticsTest {

return true;

}

- JSONStringValueSerializer json(json_data);

+ JSONStringValueDeserializer json(json_data);

int error_code = base::JSONReader::JSON_NO_ERROR;

std::string error_message;

scoped_ptr<base::Value> json_root(