Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 925593004: [CSS Grid Layout] Remove old FIXME in RenderGrid::placeItemsOnGrid() (Closed)

Created:
5 years, 10 months ago by Manuel Rego
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, svillar, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Remove old FIXME in RenderGrid::placeItemsOnGrid() There was a FIXME about not re-resolving positions if the grid is grown during auto-placement. But as the spec has changed [1] and you can only refer to the explicit grid (even if you use for example grid-column: 1 / -1). It seems that we can get rid of this FIXME as it's not a causing a problem anymore. [1] http://dev.w3.org/csswg/css-grid/#grid-placement-int Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/rendering/RenderGrid.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Manuel Rego
5 years, 10 months ago (2015-02-19 15:18:03 UTC) #2
Julien - ping for review
lgtm
5 years, 10 months ago (2015-02-21 00:34:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925593004/1
5 years, 10 months ago (2015-02-21 00:34:23 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 01:57:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190608

Powered by Google App Engine
This is Rietveld 408576698