Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 925583002: Add missing FrameState to JSTypedLoweringTester::Binop. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing FrameState to JSTypedLoweringTester::Binop. R=titzer@chromium.org TEST=cctest/test-js-typed-lowering Committed: https://crrev.com/d202d79a6a2289586140c3c5672d94d217710d3b Cr-Commit-Position: refs/heads/master@{#26626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-12 16:41:38 UTC) #1
titzer
5 years, 10 months ago (2015-02-12 16:49:36 UTC) #2
titzer
lgtm
5 years, 10 months ago (2015-02-12 16:49:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925583002/1
5 years, 10 months ago (2015-02-12 16:50:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 17:08:52 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 17:11:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d202d79a6a2289586140c3c5672d94d217710d3b
Cr-Commit-Position: refs/heads/master@{#26626}

Powered by Google App Engine
This is Rietveld 408576698