Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: test/cctest/compiler/test-js-typed-lowering.cc

Issue 925583002: Add missing FrameState to JSTypedLoweringTester::Binop. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-js-typed-lowering.cc
diff --git a/test/cctest/compiler/test-js-typed-lowering.cc b/test/cctest/compiler/test-js-typed-lowering.cc
index cf252c4c6c75843d87fe2883a05527e7bb3fb202..f4531d3e83f16ee36671d87b427b836bd1be397d 100644
--- a/test/cctest/compiler/test-js-typed-lowering.cc
+++ b/test/cctest/compiler/test-js-typed-lowering.cc
@@ -114,7 +114,12 @@ class JSTypedLoweringTester : public HandleAndZoneScope {
Node* Binop(const Operator* op, Node* left, Node* right) {
// JS binops also require context, effect, and control
- return graph.NewNode(op, left, right, context(), start(), control());
+ if (OperatorProperties::HasFrameStateInput(op)) {
+ return graph.NewNode(op, left, right, context(),
+ EmptyFrameState(context()), start(), control());
+ } else {
+ return graph.NewNode(op, left, right, context(), start(), control());
+ }
}
Node* Unop(const Operator* op, Node* input) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698