src/isolate.h - Issue 924943006: CodeTracer should open file in binary mode to avoid line endings normalization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.h

Issue 924943006: CodeTracer should open file in binary mode to avoid line endings normalization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/isolate.h

diff --git a/src/isolate.h b/src/isolate.h

index 4fb8272cf5b7da77d2b1275cb03615d947e7b296..35443d79dd51c1c1430a6aea0cc5feecd012b0b2 100644

--- a/src/isolate.h

+++ b/src/isolate.h

@@ -1561,7 +1561,7 @@ class CodeTracer FINAL : public Malloced {

}

if (file_ == NULL) {

- file_ = base::OS::FOpen(filename_.start(), "a");

+ file_ = base::OS::FOpen(filename_.start(), "ab");

}

scope_depth_++;

« no previous file with comments | « no previous file | no next file » | no next file with comments »