Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: src/isolate.h

Issue 924943006: CodeTracer should open file in binary mode to avoid line endings normalization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ISOLATE_H_ 5 #ifndef V8_ISOLATE_H_
6 #define V8_ISOLATE_H_ 6 #define V8_ISOLATE_H_
7 7
8 #include <queue> 8 #include <queue>
9 #include "include/v8-debug.h" 9 #include "include/v8-debug.h"
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 1543 matching lines...) Expand 10 before | Expand all | Expand 10 after
1554 private: 1554 private:
1555 CodeTracer* tracer_; 1555 CodeTracer* tracer_;
1556 }; 1556 };
1557 1557
1558 void OpenFile() { 1558 void OpenFile() {
1559 if (!ShouldRedirect()) { 1559 if (!ShouldRedirect()) {
1560 return; 1560 return;
1561 } 1561 }
1562 1562
1563 if (file_ == NULL) { 1563 if (file_ == NULL) {
1564 file_ = base::OS::FOpen(filename_.start(), "a"); 1564 file_ = base::OS::FOpen(filename_.start(), "ab");
1565 } 1565 }
1566 1566
1567 scope_depth_++; 1567 scope_depth_++;
1568 } 1568 }
1569 1569
1570 void CloseFile() { 1570 void CloseFile() {
1571 if (!ShouldRedirect()) { 1571 if (!ShouldRedirect()) {
1572 return; 1572 return;
1573 } 1573 }
1574 1574
(...skipping 11 matching lines...) Expand all
1586 } 1586 }
1587 1587
1588 EmbeddedVector<char, 128> filename_; 1588 EmbeddedVector<char, 128> filename_;
1589 FILE* file_; 1589 FILE* file_;
1590 int scope_depth_; 1590 int scope_depth_;
1591 }; 1591 };
1592 1592
1593 } } // namespace v8::internal 1593 } } // namespace v8::internal
1594 1594
1595 #endif // V8_ISOLATE_H_ 1595 #endif // V8_ISOLATE_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698