Issue 924943006: CodeTracer should open file in binary mode to avoid line endings normalization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 924943006: CodeTracer should open file in binary mode to avoid line endings normalization. (Closed)

Created:
5 years, 10 months ago by Vyacheslav Egorov (Google)

Modified:
5 years, 10 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

CodeTracer should open file in binary mode to avoid line endings normalization. Committed: https://crrev.com/305c73477c1ba5fd21be97229b5b404ed15faa61 Cr-Commit-Position: refs/heads/master@{#26678}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/isolate.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Vyacheslav Egorov (Google)

PTAL On Windows line endings normalization makes original line endings unrecoverable and as a result ...

5 years, 10 months ago (2015-02-16 23:43:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924943006/1

5 years, 10 months ago (2015-02-17 07:33:27 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-17 07:55:59 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/305c73477c1ba5fd21be97229b5b404ed15faa61
Cr-Commit-Position: refs/heads/master@{#26678}