Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 924803004: Remove uses of WaitForExitCode (Closed)

Created:
5 years, 10 months ago by rvargas (doing something else)
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove uses of WaitForExitCode BUG=417532 Committed: https://crrev.com/408589a9639e6fa492abe0aca8418c1894a1e682 Cr-Commit-Position: refs/heads/master@{#316335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/gn/exec_process.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
rvargas (doing something else)
5 years, 10 months ago (2015-02-13 23:43:59 UTC) #2
brettw
lgtm
5 years, 10 months ago (2015-02-13 23:51:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924803004/1
5 years, 10 months ago (2015-02-13 23:57:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 00:02:53 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 00:03:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/408589a9639e6fa492abe0aca8418c1894a1e682
Cr-Commit-Position: refs/heads/master@{#316335}

Powered by Google App Engine
This is Rietveld 408576698