Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: tools/gn/exec_process.cc

Issue 924803004: Remove uses of WaitForExitCode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/exec_process.cc
diff --git a/tools/gn/exec_process.cc b/tools/gn/exec_process.cc
index 033bb6beb6a57fa0634a6a012ce85c9ff38e2d43..d499921a1f307cc8f2ce2caf7ce81b59cd032523 100644
--- a/tools/gn/exec_process.cc
+++ b/tools/gn/exec_process.cc
@@ -7,6 +7,7 @@
#include "base/logging.h"
#include "base/process/kill.h"
#include "base/process/launch.h"
+#include "base/process/process.h"
#if defined(OS_WIN)
#include <windows.h>
@@ -235,7 +236,8 @@ bool ExecProcess(const base::CommandLine& cmdline,
err_open = ReadFromPipe(err_read.get(), std_err);
}
- return base::WaitForExitCode(pid, exit_code);
+ base::Process process(pid);
+ return process.WaitForExit(exit_code);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698