components/bookmarks/browser/bookmark_codec.h - Issue 924793003: Cleanup: Convert const char* kFoo to const char kFoo[].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_codec.h

Issue 924793003: Cleanup: Convert const char* kFoo to const char kFoo[]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/themes/theme_service.cc ('k') | components/bookmarks/browser/bookmark_codec.cc » ('j') | sandbox/linux/suid/common/suid_unsafe_environment_variables.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_codec.h

diff --git a/components/bookmarks/browser/bookmark_codec.h b/components/bookmarks/browser/bookmark_codec.h

index 761ee48c840b146d6f31d34d84cf372f4064c263..b2880ed169bf1c66bf05a5b31ba2164605e88d3b 100644

--- a/components/bookmarks/browser/bookmark_codec.h

+++ b/components/bookmarks/browser/bookmark_codec.h

@@ -85,25 +85,25 @@ class BookmarkCodec {

bool ids_reassigned() const { return ids_reassigned_; }

// Names of the various keys written to the Value.

- static const char* kRootsKey;

- static const char* kRootFolderNameKey;

- static const char* kOtherBookmarkFolderNameKey;

- static const char* kMobileBookmarkFolderNameKey;

- static const char* kVersionKey;

- static const char* kChecksumKey;

- static const char* kIdKey;

- static const char* kTypeKey;

- static const char* kNameKey;

- static const char* kDateAddedKey;

- static const char* kURLKey;

- static const char* kDateModifiedKey;

- static const char* kChildrenKey;

- static const char* kMetaInfo;

- static const char* kSyncTransactionVersion;

+ static const char kRootsKey[];

+ static const char kRootFolderNameKey[];

+ static const char kOtherBookmarkFolderNameKey[];

+ static const char kMobileBookmarkFolderNameKey[];

+ static const char kVersionKey[];

+ static const char kChecksumKey[];

+ static const char kIdKey[];

+ static const char kTypeKey[];

+ static const char kNameKey[];

+ static const char kDateAddedKey[];

+ static const char kURLKey[];

+ static const char kDateModifiedKey[];

+ static const char kChildrenKey[];

+ static const char kMetaInfo[];

+ static const char kSyncTransactionVersion[];

// Possible values for kTypeKey.

- static const char* kTypeURL;

- static const char* kTypeFolder;

+ static const char kTypeURL[];

+ static const char kTypeFolder[];

private:

// Encodes node and all its children into a Value object and returns it.