Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Side by Side Diff: components/bookmarks/browser/bookmark_codec.h

Issue 924793003: Cleanup: Convert const char* kFoo to const char kFoo[]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_ 5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_
6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_ 6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 // Return the sync transaction version of the bookmark model root. 78 // Return the sync transaction version of the bookmark model root.
79 int64 model_sync_transaction_version() const { 79 int64 model_sync_transaction_version() const {
80 return model_sync_transaction_version_; 80 return model_sync_transaction_version_;
81 } 81 }
82 82
83 // Returns whether the IDs were reassigned during decoding. Always returns 83 // Returns whether the IDs were reassigned during decoding. Always returns
84 // false after encoding. 84 // false after encoding.
85 bool ids_reassigned() const { return ids_reassigned_; } 85 bool ids_reassigned() const { return ids_reassigned_; }
86 86
87 // Names of the various keys written to the Value. 87 // Names of the various keys written to the Value.
88 static const char* kRootsKey; 88 static const char kRootsKey[];
89 static const char* kRootFolderNameKey; 89 static const char kRootFolderNameKey[];
90 static const char* kOtherBookmarkFolderNameKey; 90 static const char kOtherBookmarkFolderNameKey[];
91 static const char* kMobileBookmarkFolderNameKey; 91 static const char kMobileBookmarkFolderNameKey[];
92 static const char* kVersionKey; 92 static const char kVersionKey[];
93 static const char* kChecksumKey; 93 static const char kChecksumKey[];
94 static const char* kIdKey; 94 static const char kIdKey[];
95 static const char* kTypeKey; 95 static const char kTypeKey[];
96 static const char* kNameKey; 96 static const char kNameKey[];
97 static const char* kDateAddedKey; 97 static const char kDateAddedKey[];
98 static const char* kURLKey; 98 static const char kURLKey[];
99 static const char* kDateModifiedKey; 99 static const char kDateModifiedKey[];
100 static const char* kChildrenKey; 100 static const char kChildrenKey[];
101 static const char* kMetaInfo; 101 static const char kMetaInfo[];
102 static const char* kSyncTransactionVersion; 102 static const char kSyncTransactionVersion[];
103 103
104 // Possible values for kTypeKey. 104 // Possible values for kTypeKey.
105 static const char* kTypeURL; 105 static const char kTypeURL[];
106 static const char* kTypeFolder; 106 static const char kTypeFolder[];
107 107
108 private: 108 private:
109 // Encodes node and all its children into a Value object and returns it. 109 // Encodes node and all its children into a Value object and returns it.
110 // The caller takes ownership of the returned object. 110 // The caller takes ownership of the returned object.
111 base::Value* EncodeNode(const BookmarkNode* node); 111 base::Value* EncodeNode(const BookmarkNode* node);
112 112
113 // Encodes the given meta info into a Value object and returns it. The caller 113 // Encodes the given meta info into a Value object and returns it. The caller
114 // takes ownership of the returned object. 114 // takes ownership of the returned object.
115 base::Value* EncodeMetaInfo(const BookmarkNode::MetaInfoMap& meta_info_map); 115 base::Value* EncodeMetaInfo(const BookmarkNode::MetaInfoMap& meta_info_map);
116 116
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 202
203 // Sync transaction version set on bookmark model root. 203 // Sync transaction version set on bookmark model root.
204 int64 model_sync_transaction_version_; 204 int64 model_sync_transaction_version_;
205 205
206 DISALLOW_COPY_AND_ASSIGN(BookmarkCodec); 206 DISALLOW_COPY_AND_ASSIGN(BookmarkCodec);
207 }; 207 };
208 208
209 } // namespace bookmarks 209 } // namespace bookmarks
210 210
211 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_ 211 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_CODEC_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698