net/cert/multi_log_ct_verifier_unittest.cc - Issue 92443002: Extract Certificate Transparency SCTs from stapled OCSP responses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/multi_log_ct_verifier_unittest.cc

Issue 92443002: Extract Certificate Transparency SCTs from stapled OCSP responses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extract_scts

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/multi_log_ct_verifier_unittest.cc

diff --git a/net/cert/multi_log_ct_verifier_unittest.cc b/net/cert/multi_log_ct_verifier_unittest.cc

index b27abf0b8d26837c59f63af4271a88070e247fdc..041eeab4ee9dbf8c552e88d92570611c05460ce7 100644

--- a/net/cert/multi_log_ct_verifier_unittest.cc

+++ b/net/cert/multi_log_ct_verifier_unittest.cc

@@ -157,7 +157,7 @@ TEST_F(MultiLogCTVerifierTest,

ct::CTVerifyResult result;

EXPECT_NE(OK,

- verifier_->Verify(chain_, sct_list, "", &result, BoundNetLog()));

+ verifier_->Verify(chain_, "", sct_list, &result, BoundNetLog()));

Ryan Sleevi 2013/12/10 21:06:09 nit: use std::string() here, not ""

ekasper 2013/12/11 15:40:51 I didn't introduce this but I've changed it everyw

EXPECT_EQ(1U, result.unknown_logs_scts.size());

}

« net/cert/ct_verifier.h ('K') | « net/cert/multi_log_ct_verifier.cc ('k') | net/socket/ssl_client_socket.h » ('j') | net/socket/ssl_client_socket.h » ('J')