net/cert/multi_log_ct_verifier_unittest.cc - Issue 92443002: Extract Certificate Transparency SCTs from stapled OCSP responses

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/cert/multi_log_ct_verifier_unittest.cc

Issue 92443002: Extract Certificate Transparency SCTs from stapled OCSP responses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extract_scts

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "net/cert/multi_log_ct_verifier.h"	5 #include "net/cert/multi_log_ct_verifier.h"

6	6

7 #include <string>	7 #include <string>

8	8

9 #include "base/file_util.h"	9 #include "base/file_util.h"

10 #include "base/files/file_path.h"	10 #include "base/files/file_path.h"

(...skipping 139 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
150	150

151 // Change a byte inside the Log ID part of the SCT so it does	151 // Change a byte inside the Log ID part of the SCT so it does

152 // not match the log used in the tests	152 // not match the log used in the tests

153 sct[15] = 't';	153 sct[15] = 't';

154	154

155 std::string sct_list;	155 std::string sct_list;

156 ASSERT_TRUE(ct::EncodeSCTListForTesting(sct, &sct_list));	156 ASSERT_TRUE(ct::EncodeSCTListForTesting(sct, &sct_list));

157	157

158 ct::CTVerifyResult result;	158 ct::CTVerifyResult result;

159 EXPECT_NE(OK,	159 EXPECT_NE(OK,

160 verifier_->Verify(chain_, sct_list, "", &result, BoundNetLog()));	160 verifier_->Verify(chain_, "", sct_list, &result, BoundNetLog()));
	Ryan Sleevi 2013/12/10 21:06:09 nit: use std::string() here, not "" nit: use std::string() here, not "" ekasper 2013/12/11 15:40:51 I didn't introduce this but I've changed it everyw Show quoted text On 2013/12/10 21:06:09, Ryan Sleevi wrote: > nit: use std::string() here, not "" I didn't introduce this but I've changed it everywhere in this file now.
161 EXPECT_EQ(1U, result.unknown_logs_scts.size());	161 EXPECT_EQ(1U, result.unknown_logs_scts.size());

162 }	162 }

163	163

164 } // namespace	164 } // namespace

165	165

166 } // namespace net	166 } // namespace net

OLD	NEW

« net/cert/ct_verifier.h ('K') | « net/cert/multi_log_ct_verifier.cc ('k') | net/socket/ssl_client_socket.h » ('j') | net/socket/ssl_client_socket.h » ('J')