Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 924273003: Remove HitTestAction. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@hittestfilter
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove HitTestAction. We no longer paint background and foreground separately, so we don't need to hit test them separately. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/73e3e7a822e02d8a5cd6e3237cacd047dabeb51a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -49 lines) Patch
M sky/engine/core/rendering/RenderBlock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 3 chunks +9 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderImage.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLineBoxList.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLineBoxList.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 3 chunks +2 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 3 chunks +5 lines, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderParagraph.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderParagraph.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderText.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
This depends on https://codereview.chromium.org/924273002.
5 years, 10 months ago (2015-02-14 03:48:53 UTC) #2
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-14 04:19:07 UTC) #3
ojan
5 years, 10 months ago (2015-02-14 05:09:07 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
73e3e7a822e02d8a5cd6e3237cacd047dabeb51a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698