Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1921)

Issue 924273002: Remove HitTestFilter. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove HitTestFilter. Background and foreground on a layer can't be hit indepdently anymore, so merge them into a single hitTestContents call. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/10a59d12f6aa27a44bd74d1173e88482a52af4e7

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -42 lines) Patch
M sky/engine/core/rendering/RenderLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 3 chunks +8 lines, -25 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
Depends on https://codereview.chromium.org/924263002
5 years, 10 months ago (2015-02-14 03:43:59 UTC) #2
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-14 04:18:41 UTC) #3
ojan
5 years, 10 months ago (2015-02-14 05:08:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
10a59d12f6aa27a44bd74d1173e88482a52af4e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698