Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 924263002: Get rid of HitTestChildBlockBackground walk. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Get rid of HitTestChildBlockBackground walk. I'm not 100% what this was for, but looking at Blink, it appears that HitTestChildBlockBackground being different from HitTestBlockBackground had something to do with multi-column/regions, which we don't have. I believe this patch doesn't change any behavior. Also added to the elementFromPoint test in order to get more test coverage of the hitTesting code. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ed0316fc3b31da1686163f3161c063983c1ab43c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -15 lines) Patch
M sky/engine/core/rendering/RenderBlock.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -4 lines 1 comment Download
M sky/tests/layout/document-elementFromPoint.sky View 2 chunks +24 lines, -2 lines 0 comments Download
M sky/tests/layout/document-elementFromPoint-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
https://codereview.chromium.org/924263002/diff/1/sky/engine/core/rendering/RenderObject.cpp File sky/engine/core/rendering/RenderObject.cpp (left): https://codereview.chromium.org/924263002/diff/1/sky/engine/core/rendering/RenderObject.cpp#oldcode1686 sky/engine/core/rendering/RenderObject.cpp:1686: inside = nodeAtPoint(request, result, locationInContainer, accumulatedOffset, HitTestChildBlockBackgrounds); If the ...
5 years, 10 months ago (2015-02-14 03:25:49 UTC) #2
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-14 04:18:01 UTC) #3
ojan
5 years, 10 months ago (2015-02-14 05:06:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ed0316fc3b31da1686163f3161c063983c1ab43c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698