Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: sky/engine/core/rendering/RenderObject.cpp

Issue 924263002: Get rid of HitTestChildBlockBackground walk. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderObject.h ('k') | sky/tests/layout/document-elementFromPoint.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderObject.cpp
diff --git a/sky/engine/core/rendering/RenderObject.cpp b/sky/engine/core/rendering/RenderObject.cpp
index ea5bb1fac69ff40a524af8a9b73250cebc1ac9a3..b9afa5dcbb1fa536ea830a6527740faea35f139a 100644
--- a/sky/engine/core/rendering/RenderObject.cpp
+++ b/sky/engine/core/rendering/RenderObject.cpp
@@ -1680,10 +1680,6 @@ bool RenderObject::hitTest(const HitTestRequest& request, HitTestResult& result,
if (hitTestFilter != HitTestSelf) {
// First test the foreground layer (lines and inlines).
inside = nodeAtPoint(request, result, locationInContainer, accumulatedOffset, HitTestForeground);
-
- // Finally test to see if the mouse is in the background (within a child block's background).
- if (!inside)
- inside = nodeAtPoint(request, result, locationInContainer, accumulatedOffset, HitTestChildBlockBackgrounds);
ojan 2015/02/14 03:25:49 If the hitTest is in a child block's background it
}
// See if the mouse is inside us but not any of our descendants
« no previous file with comments | « sky/engine/core/rendering/RenderObject.h ('k') | sky/tests/layout/document-elementFromPoint.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698