Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 92383002: Mark AtomicString(StringImpl*) constructor as explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 92383002: Mark AtomicString(StringImpl*) constructor as explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/Source/core/css/resolver/StyleBuilderCustom.cpp b/Source/core/css/resolver/StyleBuilderCustom.cpp

index 294dce442b53ab580025e01e70e100e35d33ce6e..a79b6e7223508af3e06540e5c47386831934cb78 100644

--- a/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -1382,7 +1382,7 @@ void StyleBuilder::oldApplyProperty(CSSPropertyID id, StyleResolverState& state,

state.style()->setUnique();

else

state.parentStyle()->setUnique();

- QualifiedName attr(nullAtom, contentValue->getStringValue().impl(), nullAtom);

+ QualifiedName attr(nullAtom, AtomicString(contentValue->getStringValue()), nullAtom);

const AtomicString& value = state.element()->getAttribute(attr);

state.style()->setContent(value.isNull() ? emptyString() : value.string(), didSet);

didSet = true;

« no previous file with comments | « Source/core/css/resolver/SharedStyleFinder.cpp ('k') | Source/core/css/resolver/StyleResolver.cpp » ('j') | Source/wtf/text/AtomicString.h » ('J')