Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: Source/core/css/resolver/SharedStyleFinder.cpp

Issue 92383002: Mark AtomicString(StringImpl*) constructor as explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/SharedStyleFinder.cpp
diff --git a/Source/core/css/resolver/SharedStyleFinder.cpp b/Source/core/css/resolver/SharedStyleFinder.cpp
index da13e1aebc544c45eb7bcc63bb138a9a43ce44cd..92890d6c3af2feb711a6a4dcab21abb536db0a2c 100644
--- a/Source/core/css/resolver/SharedStyleFinder.cpp
+++ b/Source/core/css/resolver/SharedStyleFinder.cpp
@@ -98,8 +98,9 @@ bool SharedStyleFinder::canShareStyleWithControl(Element& candidate) const
bool SharedStyleFinder::classNamesAffectedByRules(const SpaceSplitString& classNames) const
{
- for (unsigned i = 0; i < classNames.size(); ++i) {
- if (m_features.classesInRules.contains(classNames[i].impl()))
+ unsigned count = classNames.size();
+ for (unsigned i = 0; i < count; ++i) {
+ if (m_features.classesInRules.contains(classNames[i]))
return true;
}
return false;
@@ -194,7 +195,7 @@ bool SharedStyleFinder::canShareStyleWithElement(Element& candidate) const
return false;
if (candidate.additionalPresentationAttributeStyle() != element().additionalPresentationAttributeStyle())
return false;
- if (candidate.hasID() && m_features.idsInRules.contains(candidate.idForStyleResolution().impl()))
+ if (candidate.hasID() && m_features.idsInRules.contains(candidate.idForStyleResolution()))
return false;
if (candidate.hasScopedHTMLStyleChild())
return false;
@@ -228,7 +229,7 @@ bool SharedStyleFinder::canShareStyleWithElement(Element& candidate) const
return false;
if (parent->isSVGElement() && toSVGElement(parent)->animatedSMILStyleProperties())
return false;
- if (parent->hasID() && m_features.idsInRules.contains(parent->idForStyleResolution().impl()))
+ if (parent->hasID() && m_features.idsInRules.contains(parent->idForStyleResolution()))
return false;
if (!parent->childrenSupportStyleSharing())
return false;

Powered by Google App Engine
This is Rietveld 408576698