Issue 92383002: Mark AtomicString(StringImpl*) constructor as explicit

Issue 92383002: Mark AtomicString(StringImpl*) constructor as explicit (Closed)

Created:
7 years ago by Inactive

Modified:
7 years ago

Reviewers:
tkent, abarth-chromium, eseidel

CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Mark AtomicString(StringImpl*) constructor as explicit Mark AtomicString(StringImpl*) constructor as explicit as calling it has a cost and it is called inadvertently in several places. R=abarth BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162799

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -15 lines)			Patch
M	Source/core/css/CSSPrimitiveValue.cpp	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	Source/core/css/resolver/SharedStyleFinder.cpp	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/QualifiedName.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/SetNodeAttributeCommand.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/html/forms/FormController.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/wtf/text/AtomicString.h	View	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/92383002/diff/1/Source/wtf/text/AtomicString.h File Source/wtf/text/AtomicString.h (right): https://codereview.chromium.org/92383002/diff/1/Source/wtf/text/AtomicString.h#newcode58 Source/wtf/text/AtomicString.h:58: explicit AtomicString(StringImpl* imp) : m_string(add(imp)) { } So ...

7 years ago (2013-11-27 20:20:59 UTC) #3

Inactive

https://codereview.chromium.org/92383002/diff/1/Source/wtf/text/AtomicString.h File Source/wtf/text/AtomicString.h (right): https://codereview.chromium.org/92383002/diff/1/Source/wtf/text/AtomicString.h#newcode58 Source/wtf/text/AtomicString.h:58: explicit AtomicString(StringImpl* imp) : m_string(add(imp)) { } On 2013/11/27 ...

7 years ago (2013-11-27 20:33:24 UTC) #4

commit-bot: I haz the power